Update of TFM & dependency optimisation #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oformaniuk
requested changes
Apr 2, 2024
|
I don't see a benefit in adding dotnet 8 as the dotnet 6 compilation will be used. Will remove net 5. Thoughts on also dropping net 452, net 46 as it is the same as the net 451 compilation. |
thompson-tomo
changed the title
thompson-tomo
force-pushed
the
chore/#573_AddAdditionalTFM
branch
from
6c9f3a4 to
6465f65
Compare
oformaniuk
approved these changes
Apr 2, 2024
Yes, this is a good idea to optimize monikers 👍 |
|
|
@oformaniuk i have just gone & dropped those 2 TFM's from the package. |
|
@thompson-tomo , CI pipeline is now broken: https://github.com/Handlebars-Net/Handlebars.Net/actions/runs/8524444266/job/23349047350 |
|
@oformaniuk should be Fixed in #579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adjusting the TFM'S we have been able to produce a package with no dependencies on the latest frameworks hence an optimised dependency graph.
The following frameworks have been added:
The following frameworks even though requested was not added:
The following frameworks were removed:
Closes: #573
Closes: #415